fix(progress): 5770 - Adding value for accessibility attributes into … #5819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
apps/www/__registry__/index.tsx
Outdated
| @@ -11,7 +11,7 @@ export const Index: Record<string, any> = { | |||
| type: "registry:ui", | |||
| registryDependencies: undefined, | |||
| files: [{ | |||
| path: "/Users/shadcn/Code/shadcn/ui/apps/www/registry/new-york/ui/accordion.tsx", | |||
| path: "/Users/antoinefamibelle/Develop/shadcn-ui/apps/www/registry/new-york/ui/accordion.tsx", | |||
There was a problem hiding this comment.
careful, seems your pnpm build:registry mightve changed some unintended things in index.tsx here
There was a problem hiding this comment.
In fact ! I pushed a fix sorry for the incovenience !
There was a problem hiding this comment.
hm still seems to of changed something, not sure the best way to revert this type of registry change
There was a problem hiding this comment.
Yes my bad I've removed it from the commit completly sorry for the inconvenience. 👍
antoinefamibelle
force-pushed
the
fix/5770-progress-bar-accessibility-attributes
branch
from
b10ffec
to
ae8d676
Compare
…the progress component
antoinefamibelle
force-pushed
the
fix/5770-progress-bar-accessibility-attributes
branch
from
ae8d676
to
436ab12
Compare
Jacksonmills
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This pull request addresses #5770.
Changes
Don't hesitate to reach out to me if anything is wrong about it.